Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 10914076: ExtensionService: Delay non-critical IO until after startup has finished. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ResetExternalUpdateCheckGuard() -> ResetExternalUpdateCheckGuardForTests() Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 7b025ad690cb47b3303dd5be45e6641294ec5eb8..9d52cb9ac1e414c694d03733f20486894434f521 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -380,6 +380,13 @@ class ExtensionService
// Check for updates (or potentially new extensions from external providers)
void CheckForExternalUpdates();
+ // For testing: CheckForExternalUpdates() is idempotent. Reset the flag
+ // that causes the function to perform an early return after it's first
+ // invocation.
+ void ResetExternalUpdateCheckGuardForTests() {
+ external_update_check_has_run_ = false;
+ }
+
// Unload the specified extension.
virtual void UnloadExtension(
const std::string& extension_id,
@@ -894,6 +901,9 @@ class ExtensionService
// has fired.
bool ready_;
+ // Have we done an external update check yet?
+ bool external_update_check_has_run_;
+
// Our extension updater, if updates are turned on.
scoped_ptr<extensions::ExtensionUpdater> updater_;
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698