[filemanager] Implementing undo delete functionality.

[filemanager] Implementing undo delete functionality.

BUG=126869
TEST=See bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155723

[dgozman, 2012-09-04 14:17:41]

Please take a look.

[Vladislav Kaznacheev, 2012-09-04 14:50:38]

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/butter_bar.js (right):

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/butter_bar.js:295:
ButterBar.prototype.initiateDelete = function(entries) {
It feels unnatural to have this functionality in this class. Especially as we
are going to include it into the Gallery which has no butter bar.

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_copy_manager_wrapper.js
(right):

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_copy_manager_wrapper.js:118: *
Decorates a FileTasks method, so it will be actually executed after the tasks
JSDoc copied from FileTasks too literally

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:2649: /*    if (!force)
{
Commented code

[dgozman, 2012-09-07 11:05:09]

PTAL

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/butter_bar.js (right):

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/butter_bar.js:295:
ButterBar.prototype.initiateDelete = function(entries) {
On 2012/09/04 14:50:38, Vladislav Kaznacheev wrote:
> It feels unnatural to have this functionality in this class. Especially as we
> are going to include it into the Gallery which has no butter bar.

Butter bar has to own the deleteTaskId. So, I think it's ok to just make butter
bar an owner of delete operation.
As discussed offline, prompt will be merged to butter bar.

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_copy_manager_wrapper.js
(right):

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_copy_manager_wrapper.js:118: *
Decorates a FileTasks method, so it will be actually executed after the tasks
On 2012/09/04 14:50:38, Vladislav Kaznacheev wrote:
> JSDoc copied from FileTasks too literally

Done.

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10914075/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:2649: /*    if (!force)
{
On 2012/09/04 14:50:38, Vladislav Kaznacheev wrote:
> Commented code

Done.

[Vladislav Kaznacheev, 2012-09-07 12:44:55]

lgtm

[commit-bot: I haz the power, 2012-09-07 12:48:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/10914075/8001

[commit-bot: I haz the power, 2012-09-07 14:37:58]

Try job failure for 10914075-8001 (retry) on mac_rel for step
"sync_integration_tests".
It's a second try, previously, step "sync_integration_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-09-10 12:26:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/10914075/8001

[commit-bot: I haz the power, 2012-09-10 14:32:45]

Change committed as 155723