Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10914066: Remove old implementation of binary double operations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 11758)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -1735,56 +1735,6 @@
}
-LocationSummary* BinaryDoubleOpComp::MakeLocationSummary() const {
- return MakeCallSummary(); // Calls into a stub for allocation.
-}
-
-
-void BinaryDoubleOpComp::EmitNativeCode(FlowGraphCompiler* compiler) {
- Register left = EBX;
- Register right = ECX;
- Register temp = EDX;
- Register result = locs()->out().reg();
-
- const Class& double_class = compiler->double_class();
- const Code& stub =
- Code::Handle(StubCode::GetAllocationStubForClass(double_class));
- const ExternalLabel label(double_class.ToCString(), stub.EntryPoint());
- compiler->GenerateCall(instance_call()->token_pos(),
- &label,
- PcDescriptors::kOther,
- locs());
- // Newly allocated object is now in the result register (RAX).
- ASSERT(result == EAX);
- __ movl(right, Address(ESP, 0));
- __ movl(left, Address(ESP, kWordSize));
-
- Label* deopt = compiler->AddDeoptStub(instance_call()->deopt_id(),
- kDeoptBinaryDoubleOp);
-
- // Binary operation of two Smi's produces a Smi not a double.
- __ movl(temp, left);
- __ orl(temp, right);
- __ testl(temp, Immediate(kSmiTagMask));
- __ j(ZERO, deopt);
-
- compiler->LoadDoubleOrSmiToXmm(XMM0, left, temp, deopt);
- compiler->LoadDoubleOrSmiToXmm(XMM1, right, temp, deopt);
-
- switch (op_kind()) {
- case Token::kADD: __ addsd(XMM0, XMM1); break;
- case Token::kSUB: __ subsd(XMM0, XMM1); break;
- case Token::kMUL: __ mulsd(XMM0, XMM1); break;
- case Token::kDIV: __ divsd(XMM0, XMM1); break;
- default: UNREACHABLE();
- }
-
- __ movsd(FieldAddress(result, Double::value_offset()), XMM0);
-
- __ Drop(2);
-}
-
-
LocationSummary* CheckEitherNonSmiComp::MakeLocationSummary() const {
ASSERT((left()->ResultCid() != kDoubleCid) &&
(right()->ResultCid() != kDoubleCid));
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698