Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10914066: Remove old implementation of binary double operations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 11758)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -20,7 +20,6 @@
DEFINE_FLAG(bool, trace_optimization, false, "Print optimization details.");
DECLARE_FLAG(bool, trace_type_check_elimination);
DEFINE_FLAG(bool, use_cha, true, "Use class hierarchy analysis.");
-DEFINE_FLAG(bool, use_unboxed_doubles, true, "Try unboxing double values.");
void FlowGraphOptimizer::ApplyICData() {
VisitBlocks();
@@ -450,31 +449,26 @@
ASSERT(comp->ArgumentCount() == 2);
if (operands_type == kDoubleCid) {
- if (FLAG_use_unboxed_doubles) {
- Value* left = comp->ArgumentAt(0)->value();
- Value* right = comp->ArgumentAt(1)->value();
+ Value* left = comp->ArgumentAt(0)->value();
+ Value* right = comp->ArgumentAt(1)->value();
- // Check that either left or right are not a smi. Result or a
- // binary operation with two smis is a smi not a double.
- InsertBefore(instr,
- new CheckEitherNonSmiComp(left->Copy(),
- right->Copy(),
- comp),
- instr->env(),
- BindInstr::kUnused);
+ // Check that either left or right are not a smi. Result or a
+ // binary operation with two smis is a smi not a double.
+ InsertBefore(instr,
+ new CheckEitherNonSmiComp(left->Copy(),
+ right->Copy(),
+ comp),
+ instr->env(),
+ BindInstr::kUnused);
- UnboxedDoubleBinaryOpComp* double_bin_op =
- new UnboxedDoubleBinaryOpComp(op_kind,
- left->Copy(),
- right->Copy(),
- comp);
- instr->set_computation(double_bin_op);
+ UnboxedDoubleBinaryOpComp* double_bin_op =
+ new UnboxedDoubleBinaryOpComp(op_kind,
+ left->Copy(),
+ right->Copy(),
+ comp);
+ instr->set_computation(double_bin_op);
- RemovePushArguments(comp);
- } else {
- BinaryDoubleOpComp* double_bin_op = new BinaryDoubleOpComp(op_kind, comp);
- instr->set_computation(double_bin_op);
- }
+ RemovePushArguments(comp);
} else if (operands_type == kMintCid) {
Value* left = comp->ArgumentAt(0)->value();
Value* right = comp->ArgumentAt(1)->value();
« no previous file with comments | « no previous file | runtime/vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698