Remove old implementation of binary double operations.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/hash_map.h"
 #include "vm/il_printer.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/scopes.h"
 #include "vm/symbols.h"
 
 namespace dart {
 
 DECLARE_FLAG(bool, eliminate_type_checks);
 DECLARE_FLAG(bool, enable_type_checks);
 DEFINE_FLAG(bool, trace_optimization, false, "Print optimization details.");
 DECLARE_FLAG(bool, trace_type_check_elimination);
 DEFINE_FLAG(bool, use_cha, true, "Use class hierarchy analysis.");
-DEFINE_FLAG(bool, use_unboxed_doubles, true, "Try unboxing double values.");
 
 void FlowGraphOptimizer::ApplyICData() {
   VisitBlocks();
 }
 
 
 void FlowGraphOptimizer::OptimizeComputations() {
   for (intptr_t i = 0; i < block_order_.length(); ++i) {
     BlockEntryInstr* entry = block_order_[i];
     entry->Accept(this);
@@ skipping 409 matching lines @@
       } else {
         return false;
       }
       break;
     default:
       UNREACHABLE();
   };
 
   ASSERT(comp->ArgumentCount() == 2);
   if (operands_type == kDoubleCid) {
-    if (FLAG_use_unboxed_doubles) {
-      Value* left = comp->ArgumentAt(0)->value();
-      Value* right = comp->ArgumentAt(1)->value();
+    Value* left = comp->ArgumentAt(0)->value();
+    Value* right = comp->ArgumentAt(1)->value();
 
-      // Check that either left or right are not a smi.  Result or a
-      // binary operation with two smis is a smi not a double.
-      InsertBefore(instr,
-                   new CheckEitherNonSmiComp(left->Copy(),
-                                             right->Copy(),
-                                             comp),
-                   instr->env(),
-                   BindInstr::kUnused);
+    // Check that either left or right are not a smi.  Result or a
+    // binary operation with two smis is a smi not a double.
+    InsertBefore(instr,
+                 new CheckEitherNonSmiComp(left->Copy(),
+                                           right->Copy(),
+                                           comp),
+                 instr->env(),
+                 BindInstr::kUnused);
 
-      UnboxedDoubleBinaryOpComp* double_bin_op =
-          new UnboxedDoubleBinaryOpComp(op_kind,
-                                        left->Copy(),
-                                        right->Copy(),
-                                        comp);
-      instr->set_computation(double_bin_op);
+    UnboxedDoubleBinaryOpComp* double_bin_op =
+        new UnboxedDoubleBinaryOpComp(op_kind,
+                                      left->Copy(),
+                                      right->Copy(),
+                                      comp);
+    instr->set_computation(double_bin_op);
 
-      RemovePushArguments(comp);
-    } else {
-      BinaryDoubleOpComp* double_bin_op = new BinaryDoubleOpComp(op_kind, comp);
-      instr->set_computation(double_bin_op);
-    }
+    RemovePushArguments(comp);
   } else if (operands_type == kMintCid) {
     Value* left = comp->ArgumentAt(0)->value();
     Value* right = comp->ArgumentAt(1)->value();
     BinaryMintOpComp* bin_op = new BinaryMintOpComp(op_kind,
                                                     comp,
                                                     left,
                                                     right);
     instr->set_computation(bin_op);
     RemovePushArguments(comp);
   } else {
@@ skipping 717 matching lines @@
       DirectChainedHashMap<BindInstr*> child_map(*map);  // Copy map.
       OptimizeRecursive(child, &child_map);
     } else {
       OptimizeRecursive(child, map);  // Reuse map for the last child.
     }
   }
 }
 
 
 }  // namespace dart