Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc

Issue 10914060: Refine systemInfo.cpu API defintions and provide systemInfo.cpu.get impl for Windows and Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc
diff --git a/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc b/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc
index fcd5cb9d808553b1e41eac18b5d4191d3356ba8a..b516c97a21aac4e93677f7dafbecc1d6996332bd 100644
--- a/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc
+++ b/chrome/browser/extensions/api/system_info_cpu/system_info_cpu_apitest.cc
@@ -10,7 +10,6 @@
namespace extensions {
using api::experimental_system_info_cpu::CpuInfo;
-using api::experimental_system_info_cpu::CpuCoreInfo;
class MockCpuInfoProviderImpl : public CpuInfoProvider {
public:
@@ -18,16 +17,12 @@ class MockCpuInfoProviderImpl : public CpuInfoProvider {
~MockCpuInfoProviderImpl() {}
virtual bool QueryInfo(CpuInfo* info) OVERRIDE {
- DCHECK(info);
+ if (!info) return false;
- info->cores.clear();
+ info->num_of_processors = 4;
+ info->arch_name = "x86";
+ info->model_name = "unknown";
- static const unsigned int kNumberOfCores = 4;
- for (unsigned int i = 0; i < kNumberOfCores; ++i) {
- linked_ptr<CpuCoreInfo> core(new CpuCoreInfo());
- core->load = i*10;
- info->cores.push_back(core);
- }
return true;
}
};
« no previous file with comments | « chrome/browser/extensions/api/system_info_cpu/cpu_info_provider_win.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698