Relocating files in the nacl repo that belong in chrome.

Relocating files in the nacl repo that belong in chrome.

Moving src/native_client/chrome_root.scons to
src/ppapi/native_client/chrome_main.scons (no diff)
Moving tests and components listed therein.
Moving browser_tester.

Files are unmodified except for small pathing adjustments to irt_stub.gyp and browser_tester.py to make them function in their new location, copyright header changes and one >80 line wrap.

Groundwork is laid to have a chrome side copy step in gyp be responsible for populating a few ppapi side headers.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2957
TEST=None
R=ncbray@chromium.org,noeallen@chromium.org,brettw@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155572

[bradn, 2012-09-06 07:57:46]

The DEPS roll will likely get merged away.
The buildbot script change is temporary for trybot testing.

[Nick Bray, 2012-09-06 17:11:58]

http://codereview.chromium.org/10914053/diff/12002/chrome/test/nacl_test_inje...
File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):

http://codereview.chromium.org/10914053/diff/12002/chrome/test/nacl_test_inje...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:159:
shutil.rmtree(os.path.join(nacl_dir, 'tests', 'nacl_browser'))
Don't forget: DO NOT COMMIT.  This makes it hard to review the CL.

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/native...
File ppapi/native_client/native_client.gyp (right):

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/native...
ppapi/native_client/native_client.gyp:23: #  'destination':
'<(SHARED_INTERMEDIATE_DIR)/tc_newlib/include/nacl',
Don't put this in here if it's dead?

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/src/un...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_entry.c (right):

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/src/un...
ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_entry.c:2: * Copyright (c)
2011 The Chromium Authors. All rights reserved.
Huh?  This is the first time I've seen the copyright regress.

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/src/un...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c (right):

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/src/un...
ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c:2: * Copyright (c)
2011 The Chromium Authors. All rights reserved.
Dito.  Bad merge?

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/tests/...
File ppapi/native_client/tests/examples.html (right):

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/tests/...
ppapi/native_client/tests/examples.html:20: ['hello world', 'srpc_hw.html'],
Huh?  Why are dead SRPC nexes being added?  This diff seems backward.

[bradn, 2012-09-06 18:53:16]

PTAL

http://codereview.chromium.org/10914053/diff/12002/chrome/test/nacl_test_inje...
File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):

http://codereview.chromium.org/10914053/diff/12002/chrome/test/nacl_test_inje...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:159:
shutil.rmtree(os.path.join(nacl_dir, 'tests', 'nacl_browser'))
On 2012/09/06 17:11:58, Nick Bray wrote:
> Don't forget: DO NOT COMMIT.  This makes it hard to review the CL.
:-)

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/native...
File ppapi/native_client/native_client.gyp (right):

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/native...
ppapi/native_client/native_client.gyp:23: #  'destination':
'<(SHARED_INTERMEDIATE_DIR)/tc_newlib/include/nacl',
On 2012/09/06 17:11:58, Nick Bray wrote:
> Don't put this in here if it's dead?

Done.

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/src/un...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_entry.c (right):

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/src/un...
ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_entry.c:2: * Copyright (c)
2011 The Chromium Authors. All rights reserved.
On 2012/09/06 17:11:58, Nick Bray wrote:
> Huh?  This is the first time I've seen the copyright regress.

Done.

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/src/un...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c (right):

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/src/un...
ppapi/native_client/src/untrusted/pnacl_irt_shim/shim_ppapi.c:2: * Copyright (c)
2011 The Chromium Authors. All rights reserved.
On 2012/09/06 17:11:58, Nick Bray wrote:
> Dito.  Bad merge?

Done.

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/tests/...
File ppapi/native_client/tests/examples.html (right):

http://codereview.chromium.org/10914053/diff/12002/ppapi/native_client/tests/...
ppapi/native_client/tests/examples.html:20: ['hello world', 'srpc_hw.html'],
On 2012/09/06 17:11:58, Nick Bray wrote:
> Huh?  Why are dead SRPC nexes being added?  This diff seems backward.

Done.

[brettw, 2012-09-06 20:13:21]

http://codereview.chromium.org/10914053/diff/3089/chrome/test/nacl_test_injec...
File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):

http://codereview.chromium.org/10914053/diff/3089/chrome/test/nacl_test_injec...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:78: # DO NOT COMMIT
Is this on purpose?

[bradn, 2012-09-06 20:28:26]

http://codereview.chromium.org/10914053/diff/3089/chrome/test/nacl_test_injec...
File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):

http://codereview.chromium.org/10914053/diff/3089/chrome/test/nacl_test_injec...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:78: # DO NOT COMMIT
On 2012/09/06 20:13:21, brettw wrote:
> Is this on purpose?
Yes, I don't intend to commit this, but I have included it for now as a
demonstration of the correctness of the moved files (ie that that match and that
the build functions when they are removed from the nacl side).

[Nick Bray, 2012-09-07 21:35:02]

Non-OWNER LGTM

[noelallen1, 2012-09-07 21:50:06]

lgtm

http://codereview.chromium.org/10914053/diff/5281/chrome/test/nacl_test_injec...
File chrome/test/nacl_test_injection/buildbot_nacl_integration.py (right):

http://codereview.chromium.org/10914053/diff/5281/chrome/test/nacl_test_injec...
chrome/test/nacl_test_injection/buildbot_nacl_integration.py:79: nacl_dir =
os.path.join(src_dir, 'native_client')
Do not commit?

[commit-bot: I haz the power, 2012-09-07 22:16:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10914053/7200

[commit-bot: I haz the power, 2012-09-07 22:16:51]

Presubmit check for 10914053-7200 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ppapi/native_client

Presubmit checks took 2.9s to calculate.

[noelallen_use_chromium, 2012-09-07 23:05:20]

lgtm

[commit-bot: I haz the power, 2012-09-07 23:05:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10914053/7200

[commit-bot: I haz the power, 2012-09-08 01:11:28]

Try job failure for 10914053-7200 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-09-08 01:43:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10914053/17089

[commit-bot: I haz the power, 2012-09-08 09:48:44]

Change committed as 155572