Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: vm/snapshot_test.cc

Issue 10914050: Use external byte arrays for token stream, this moves the token stream out of the isolate heap. For… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/snapshot.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/snapshot_test.cc
===================================================================
--- vm/snapshot_test.cc (revision 11973)
+++ vm/snapshot_test.cc (working copy)
@@ -723,7 +723,11 @@
const TokenStream& expected_tokens = TokenStream::Handle(script.tokens());
const TokenStream& serialized_tokens =
TokenStream::Handle(serialized_script.tokens());
- EXPECT_EQ(expected_tokens.Length(), serialized_tokens.Length());
+ const ExternalUint8Array& expected_data =
+ ExternalUint8Array::Handle(expected_tokens.GetStream());
+ const ExternalUint8Array& serialized_data =
+ ExternalUint8Array::Handle(serialized_tokens.GetStream());
+ EXPECT_EQ(expected_data.Length(), serialized_data.Length());
TokenStream::Iterator expected_iterator(expected_tokens, 0);
TokenStream::Iterator serialized_iterator(serialized_tokens, 0);
Token::Kind expected_kind = expected_iterator.CurrentTokenKind();
« no previous file with comments | « vm/snapshot.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698