Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: pkg/unittest/config.dart

Issue 10914049: Added support for layout render tests. These use expected values for the text render output from Du… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pkg.status ('k') | pkg/unittest/html_layout_config.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/config.dart
===================================================================
--- pkg/unittest/config.dart (revision 11963)
+++ pkg/unittest/config.dart (working copy)
@@ -14,6 +14,12 @@
TestCase currentTestCase = null;
/**
+ * Subclasses can override this with something useful for diagnostics.
+ * Particularly useful in cases where we have parent/child configurations
+ * such as layout tests.
+ */
+ get name => 'Configuration';
+ /**
* If true, then tests are started automatically (otherwise [runTests]
* must be called explicitly after the tests are set up.
*/
@@ -54,16 +60,16 @@
* instead of print. Subclasses should not override this; they
* should instead override logMessage which is passed the test case.
*/
- void log(String message) {
+ void logMessage(String message) {
if (currentTestCase == null || _currentTest >= _tests.length ||
currentTestCase.id != _tests[_currentTest].id) {
// Before or after tests run, or with a mismatch between what the
// config and the test harness think is the current test. In this
// case we pass null for the test case reference and let the config
// decide what to do with this.
- logMessage(null, message);
+ logTestCaseMessage(null, message);
} else {
- logMessage(currentTestCase, message);
+ logTestCaseMessage(currentTestCase, message);
}
}
@@ -71,7 +77,7 @@
* Handles the logging of messages by a test case. The default in
* this base configuration is to call print();
*/
- void logMessage(TestCase testCase, String message) {
+ void logTestCaseMessage(TestCase testCase, String message) {
print(message);
}
« no previous file with comments | « pkg/pkg.status ('k') | pkg/unittest/html_layout_config.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698