Add explicit smi-checks to smi comparisons.

runtime/vm/flow_graph_optimizer.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_OPTIMIZER_H_
 #define VM_FLOW_GRAPH_OPTIMIZER_H_
 
 #include "vm/intermediate_language.h"
 #include "vm/flow_graph.h"
 
@@ skipping 14 matching lines @@
   void OptimizeComputations();
 
   virtual void VisitStaticCall(StaticCallComp* comp, BindInstr* instr);
   virtual void VisitInstanceCall(InstanceCallComp* comp, BindInstr* instr);
   virtual void VisitRelationalOp(RelationalOpComp* comp, BindInstr* instr);
   virtual void VisitEqualityCompare(EqualityCompareComp* comp,
                                     BindInstr* instr);
   virtual void VisitBind(BindInstr* instr);
   virtual void VisitBranch(BranchInstr* instr);
 
+// TODO(fschneider): Once we get rid of the distinction between Instruction
+// and computation, this can be made private again.

[srdjan, 2012/08/30 18:36:12]

Fix comment indent.

[Florian Schneider, 2012/09/03 09:25:09]

Done.

+  BindInstr* InsertBefore(Instruction* instr,
+                          Computation* comp,
+                          Environment* env,
+                          BindInstr::UseKind use_kind);
+
  private:
   bool TryReplaceWithArrayOp(BindInstr* instr,
                              InstanceCallComp* comp,
                              Token::Kind op_kind);
   bool TryReplaceWithBinaryOp(BindInstr* instr,
                               InstanceCallComp* comp,
                               Token::Kind op_kind);
   bool TryReplaceWithUnaryOp(BindInstr* instr,
                              InstanceCallComp* comp,
                              Token::Kind op_kind);
 
   bool TryInlineInstanceGetter(BindInstr* instr,
                                InstanceCallComp* comp);
   bool TryInlineInstanceSetter(BindInstr* instr, InstanceCallComp* comp);
 
   bool TryInlineInstanceMethod(BindInstr* instr, InstanceCallComp* comp);
 
   void AddCheckClass(BindInstr* instr, InstanceCallComp* comp, Value* value);
 
-  BindInstr* InsertBefore(Instruction* instr,
-                          Computation* comp,
-                          Environment* env,
-                          BindInstr::UseKind use_kind);
-
   BindInstr* InsertAfter(Instruction* instr,
                          Computation* comp,
                          Environment* env,
                          BindInstr::UseKind use_kind);
 
   FlowGraph* flow_graph_;
 
   DISALLOW_COPY_AND_ASSIGN(FlowGraphOptimizer);
 };
 
@@ skipping 61 matching lines @@
  private:
   static void OptimizeRecursive(
       BlockEntryInstr* entry,
       DirectChainedHashMap<BindInstr*>* map);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_OPTIMIZER_H_