Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 10913309: Re-enabled unit test (BrowserNonClientFrameViewAshTest.UseShortHeader) (Closed)

Created:
8 years, 3 months ago by Mr4D (OOO till 08-26)
Modified:
8 years, 3 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Re-enabled unit test (BrowserNonClientFrameViewAshTest.UseShortHeader) BUG=149824 TEST=unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/ui/views/ash/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mr4D (OOO till 08-26)
Many thanks for reviewing!
8 years, 3 months ago (2012-09-17 23:18:34 UTC) #1
James Cook
lgtm
8 years, 3 months ago (2012-09-17 23:32:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10913309/1
8 years, 3 months ago (2012-09-18 00:22:58 UTC) #3
commit-bot: I haz the power
Presubmit check for 10913309-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-18 00:23:02 UTC) #4
Mr4D (OOO till 08-26)
Sky, please do an owners review!
8 years, 3 months ago (2012-09-18 02:55:09 UTC) #5
sky
LGTM
8 years, 3 months ago (2012-09-18 04:00:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10913309/1
8 years, 3 months ago (2012-09-18 04:22:25 UTC) #7
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 3 months ago (2012-09-18 09:36:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10913309/1
8 years, 3 months ago (2012-09-18 14:19:02 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 15:17:09 UTC) #10
Change committed as 157361

Powered by Google App Engine
This is Rietveld 408576698