Issue 10913305: Enable more Windows mitigations

Issue 10913305: Enable more Windows mitigations (Closed)

Created:
8 years, 3 months ago by jschuh

Modified:
8 years, 3 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enable more mitigations The first patch matched our previous mitigations. This adds new ones. BUG=147752 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158124

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -21 lines)			Patch
	M	content/common/sandbox_policy.cc	View	1 2 3	1 chunk	+27 lines, -21 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

jschuh

I'm not landing this until after the merge, but here it is for your queue.

8 years, 3 months ago (2012-09-18 17:52:46 UTC) #1

cpu_(ooo_6.6-7.5)

no objections on the flags. Are you missing a #if defined(NACL_WIN64) ?

8 years, 3 months ago (2012-09-19 21:16:20 UTC) #2

jschuh

On 2012/09/19 21:16:20, cpu wrote: > no objections on the flags. Are you missing a ...

8 years, 3 months ago (2012-09-20 20:46:00 UTC) #3

cpu_(ooo_6.6-7.5)

lgtm http://codereview.chromium.org/10913305/diff/7001/content/common/sandbox_policy.cc File content/common/sandbox_policy.cc (right): http://codereview.chromium.org/10913305/diff/7001/content/common/sandbox_policy.cc#newcode741 content/common/sandbox_policy.cc:741: if (policy->SetProcessMitigations(mitigations) != sandbox::SBOX_ALL_OK) can we move 739 ...

8 years, 3 months ago (2012-09-21 19:30:27 UTC) #4

jschuh

http://codereview.chromium.org/10913305/diff/7001/content/common/sandbox_policy.cc File content/common/sandbox_policy.cc (right): http://codereview.chromium.org/10913305/diff/7001/content/common/sandbox_policy.cc#newcode741 content/common/sandbox_policy.cc:741: if (policy->SetProcessMitigations(mitigations) != sandbox::SBOX_ALL_OK) On 2012/09/21 19:30:27, cpu wrote: ...

8 years, 3 months ago (2012-09-21 19:43:10 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/10913305/8002

8 years, 3 months ago (2012-09-21 19:43:42 UTC) #6

jschuh

Minor tweak. I reran a debug build and noticed that you can't enable forced ASLR ...

8 years, 3 months ago (2012-09-21 21:11:17 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/10913305/12002

8 years, 3 months ago (2012-09-21 21:11:55 UTC) #8

Change committed as 158124

Expand Messages | Collapse Messages