Issue 10913286: Convert test_shell_tests BookmarkletTest.* into a content_browsertest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913286: Convert test_shell_tests BookmarkletTest.* into a content_browsertest. (Closed)

Created:
8 years, 3 months ago by tony

Modified:
8 years, 3 months ago

Reviewers:
darin (slow to review), jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Convert test_shell_tests BookmarkletTest.* into a content_browsertest. Move from using TestShell to content::Shell. BUG=126514 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157155

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -77 lines)			Patch
A	content/browser/bookmarklet_browsertest.cc	View	1 chunk	+75 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	webkit/glue/bookmarklet_unittest.cc	View	1 chunk	+0 lines, -76 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10913286/1

8 years, 3 months ago (2012-09-17 16:54:22 UTC) #3

Change committed as 157155