Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 10913264: Make gdb-add-index better respect relative paths and bind mounts (Closed)

Created:
8 years, 3 months ago by awong
Modified:
8 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Make gdb-add-index better respect relative paths and bind mounts. Without this, gdb-add-index incorrectly skips DSO dependencies if running from a symlink. $(pwd) returns the path to your directory via the symlink, but ldd returns the "realpath". Using dirname allows you to match a substring of the path returned by ldd. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/gdb-add-index View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
awong
Without this, gdb-add-index incorrectly scripts DSO dependencies if you use --bind mount of the output ...
8 years, 3 months ago (2012-09-14 06:39:09 UTC) #1
Nico
On 2012/09/14 06:39:09, awong wrote: > Without this, gdb-add-index incorrectly scripts DSO dependencies if you ...
8 years, 3 months ago (2012-09-14 06:47:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/10913264/1
8 years, 3 months ago (2012-09-14 07:04:15 UTC) #3
awong
Example: ajwong@ajwong-linux:~/src/chromium/src$ ldd out/Debug/browser_tests linux-vdso.so.1 => (0x00007fffea5ff000) libui.so => /usr/local/data/chromium/src/out/Debug/lib/libui.so (0x00007fed3a4e4000) libgles2_c_lib.so => /usr/local/data/chromium/src/out/Debug/lib/libgles2_c_lib.so (0x00007fed3a4ad000) ...
8 years, 3 months ago (2012-09-14 07:06:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/10913264/1
8 years, 3 months ago (2012-09-14 17:42:27 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 3 months ago (2012-09-14 22:47:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajwong@chromium.org/10913264/1
8 years, 3 months ago (2012-09-15 01:26:52 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-15 02:28:21 UTC) #8
Change committed as 156968

Powered by Google App Engine
This is Rietveld 408576698