Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 10913261: cc: Remove awareness of incremental updates from state machine. (Closed)

Created:
8 years, 3 months ago by reveman
Modified:
8 years, 3 months ago
Reviewers:
jamesr, nduca
CC:
chromium-reviews
Visibility:
Public.

Description

cc: Remove awareness of incremental updates from state machine. CCScheduler handles incremental resources updates based on amount of time until next vsync tick. We currently get no benefit from having CCSchedulerStateMachine aware of these incremental updates. This cleans up both CCScheduler and CCSchedulerStateMachine be removing incremental update awareness from CCSchedulerStateMachine. WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=95290 BUG= TEST=cc_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -164 lines) Patch
M cc/CCScheduler.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/CCScheduler.cpp View 4 chunks +12 lines, -21 lines 0 comments Download
M cc/CCSchedulerStateMachine.h View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/CCSchedulerStateMachine.cpp View 7 chunks +16 lines, -14 lines 0 comments Download
M cc/CCSchedulerStateMachineTest.cpp View 22 chunks +61 lines, -121 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reveman
this is the state machine cleanup following https://chromiumcodereview.appspot.com/10911262/. has already been r+ on the webkit ...
8 years, 3 months ago (2012-09-14 22:42:20 UTC) #1
jamesr
lgtm
8 years, 3 months ago (2012-09-14 22:43:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/10913261/1
8 years, 3 months ago (2012-09-14 22:53:15 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-15 01:35:34 UTC) #4
Change committed as 156950

Powered by Google App Engine
This is Rietveld 408576698