Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3628)

Unified Diff: chrome/browser/ui/views/extensions/extension_view_views.h

Issue 10913243: extensions: Add ExtensionView interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: weak Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_view_views.h
diff --git a/chrome/browser/ui/views/extensions/extension_view_views.h b/chrome/browser/ui/views/extensions/extension_view_views.h
index 4ef9ea700353b916fb5ec1ca4e5d5414452d423a..1585be5fbc6237ccfd451ea94b145e16ef9ba8d0 100644
--- a/chrome/browser/ui/views/extensions/extension_view_views.h
+++ b/chrome/browser/ui/views/extensions/extension_view_views.h
@@ -7,13 +7,12 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "chrome/browser/extensions/extension_view.h"
#include "chrome/browser/ui/views/unhandled_keyboard_event_handler.h"
#include "content/public/browser/native_web_keyboard_event.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/views/controls/native/native_view_host.h"
-class Browser;
-
namespace content {
class RenderViewHost;
}
@@ -24,51 +23,25 @@ class ExtensionHost;
}
// This handles the display portion of an ExtensionHost.
-class ExtensionViewViews : public views::NativeViewHost {
+class ExtensionViewViews : public ExtensionView,
+ public views::NativeViewHost {
public:
ExtensionViewViews(extensions::ExtensionHost* host, Browser* browser);
virtual ~ExtensionViewViews();
- // A class that represents the container that this view is in.
- // (bottom shelf, side bar, etc.)
- class Container {
- public:
- virtual ~Container() {}
- virtual void OnExtensionSizeChanged(ExtensionViewViews* view) {}
- virtual void OnViewWasResized() {}
- };
-
- extensions::ExtensionHost* host() const { return host_; }
- Browser* browser() const { return browser_; }
- const extensions::Extension* extension() const;
- content::RenderViewHost* render_view_host() const;
- void DidStopLoading();
- void SetIsClipped(bool is_clipped);
-
- // Notification from ExtensionHost.
- void ResizeDueToAutoResize(const gfx::Size& new_size);
-
- // Method for the ExtensionHost to notify us when the RenderViewHost has a
- // connection.
- void RenderViewCreated();
-
// Set a custom background for the view. The background will be tiled.
void SetBackground(const SkBitmap& background);
- // Sets the container for this view.
- void SetContainer(Container* container) { container_ = container; }
-
- // Handles unhandled keyboard messages coming back from the renderer process.
- void HandleKeyboardEvent(const content::NativeWebKeyboardEvent& event);
+ // Overridden from views::View:
+ virtual void SetVisible(bool is_visible) OVERRIDE;
+ protected:
// Overridden from views::NativeViewHost:
virtual gfx::NativeCursor GetCursor(const ui::MouseEvent& event) OVERRIDE;
- virtual void SetVisible(bool is_visible) OVERRIDE;
virtual void ViewHierarchyChanged(bool is_add,
views::View* parent,
views::View* child) OVERRIDE;
- protected:
// Overridden from views::View.
virtual void PreferredSizeChanged() OVERRIDE;
virtual bool SkipDefaultKeyEventProcessing(const ui::KeyEvent& e) OVERRIDE;
@@ -77,6 +50,20 @@ class ExtensionViewViews : public views::NativeViewHost {
private:
friend class extensions::ExtensionHost;
+ // Overridden from ExtensionView:
+ virtual Browser* GetBrowser() OVERRIDE;
+ virtual const Browser* GetBrowser() const OVERRIDE;
+ virtual gfx::NativeView GetNativeView() OVERRIDE;
+ virtual content::RenderViewHost* GetRenderViewHost() const OVERRIDE;
+ virtual void SetContainer(ExtensionViewContainer* container) OVERRIDE;
+ virtual void ResizeDueToAutoResize(const gfx::Size& new_size) OVERRIDE;
+ virtual void RenderViewCreated() OVERRIDE;
+ virtual void DidStopLoading() OVERRIDE;
+ virtual void WindowFrameChanged() OVERRIDE;
+ virtual void HandleKeyboardEvent(
+ const content::NativeWebKeyboardEvent& event) OVERRIDE;
+
+
// Initializes the RenderWidgetHostView for this object.
void CreateWidgetHostView();
@@ -107,10 +94,7 @@ class ExtensionViewViews : public views::NativeViewHost {
// The container this view is in (not necessarily its direct superview).
// Note: the view does not own its container.
- Container* container_;
-
- // Whether this extension view is clipped.
- bool is_clipped_;
+ ExtensionViewContainer* container_;
// A handler to handle unhandled keyboard messages coming back from the
// renderer process.
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_popup.cc ('k') | chrome/browser/ui/views/extensions/extension_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698