Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Issue 10913225: Revert 156308 - Revert 156233 - Make apks be built in a consistent way (Closed)

Created:
8 years, 3 months ago by cjhopman
Modified:
8 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Revert 156308 - Revert 156233 - Make apks be built in a consistent way This broke non-incremental Android builds. In the original CL there was a discrepancy in the way that Gyp handled paths and the way that Ant handled paths. Changed it so that resource_dir is specified relative to java_in_dir so that Gyp and Ant treat it the same. For http://crbug.com/145991 I will have to make resource_dir be in a consistent location for all apk targets and at that point it can be removed from the gyp files. Original:https://chromiumcodereview.appspot.com/10914130 BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157502

Patch Set 1 : Original CL #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -70 lines) Patch
A build/java_apk.gypi View 1 1 chunk +75 lines, -0 lines 0 comments Download
M content/content_shell.gypi View 1 2 2 chunks +11 lines, -38 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +7 lines, -29 lines 0 comments Download
M content/shell/android/java/content_shell_apk.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/javatests/content_shell_test_apk.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
cjhopman
tedchoc: content/shell/android brettw: content/
8 years, 3 months ago (2012-09-12 16:36:15 UTC) #1
Ted C
lgtm http://codereview.chromium.org/10913225/diff/3006/build/java_apk.gypi File build/java_apk.gypi (right): http://codereview.chromium.org/10913225/diff/3006/build/java_apk.gypi#newcode16 build/java_apk.gypi:16: # 'resource_dir': 'res', maybe have a comment that ...
8 years, 3 months ago (2012-09-12 23:35:25 UTC) #2
cjhopman
brettw could you take a look/rubberstamp the gyp changes in content/?
8 years, 3 months ago (2012-09-18 20:33:41 UTC) #3
brettw
lgtm rubberstamp
8 years, 3 months ago (2012-09-18 21:09:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10913225/11001
8 years, 3 months ago (2012-09-18 21:32:03 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) unit_tests
8 years, 3 months ago (2012-09-19 00:56:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/10913225/11001
8 years, 3 months ago (2012-09-19 00:59:00 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-19 04:16:29 UTC) #8
Change committed as 157502

Powered by Google App Engine
This is Rietveld 408576698