Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 10913221: Fix memory leak in network_location_provider_unittest (Closed)

Created:
8 years, 3 months ago by John Knottenbelt
Modified:
8 years, 3 months ago
Reviewers:
bulach
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix memory leak in network_location_provider_unittest Use a scoped_ptr to hold the result of JSONReader::ReadAndReturnError in CheckRequestIsValid method. BUG=146354 TEST=content_unit_tests:GeolocationNetworkProviderTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156313

Patch Set 1 #

Patch Set 2 : Initial upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/browser/geolocation/network_location_provider_unittest.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
John Knottenbelt
8 years, 3 months ago (2012-09-12 11:25:55 UTC) #1
bulach
lgtm, thanks!
8 years, 3 months ago (2012-09-12 11:27:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10913221/2001
8 years, 3 months ago (2012-09-12 11:29:38 UTC) #3
commit-bot: I haz the power
Try job failure for 10913221-2001 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 3 months ago (2012-09-12 12:28:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10913221/2001
8 years, 3 months ago (2012-09-12 13:46:14 UTC) #5
commit-bot: I haz the power
Try job failure for 10913221-2001 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 3 months ago (2012-09-12 14:35:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10913221/2001
8 years, 3 months ago (2012-09-12 15:17:16 UTC) #7
commit-bot: I haz the power
Try job failure for 10913221-2001 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=27525 Step "update" is always ...
8 years, 3 months ago (2012-09-12 15:21:14 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 16:16:30 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698