chromeos: Fix eternal cellular activation spinner

chromeos: Fix eternal cellular activation spinner

Change our state machine to attempt to reconnect after entering OTASP.

While the cellular activation process is far from deterministic, it seems like
we've been hanging on getting out of OTASP because we stop trying to connect to
the provider when we enter OTASP.  At some point, this must have made sense
because the connection manager would automatically try to connect modems to
cellular service under certain conditions.  However, shill does not do this.

This seems to be a regression introduced in:

https://chromiumcodereview.appspot.com/10456045/


BUG=chromeos-partner:10294
TEST=Manually test that activation does not hang

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157422

[wiley, 2012-09-14 18:10:50]

This seems to reproducibly fix the error mentioned in the CL, but the reason for
the original change wasn't clear to me.

PTAL

[zel, 2012-09-14 18:13:51]

I suppose your assumptions about change in behavior after update to shil are
correct. Please make sure that you test the heck out of this before landing -
for both re-up and fresh activation cases.


LGTM

[wiley, 2012-09-14 18:57:26]

I've tested activation on a lumpy with a built in modem and with several
external modems on a zgb.  The re-up process seems to be broken on Verizon's
side; when I agree to the ToS and click submit it hangs and I see this in the
chrome log:

[1184:1184:0914/114001:INFO:CONSOLE(209)] "Uncaught TypeError: Object
#<Object> has no method 'submit'", source:
https://quickaccess.verizonwireless.com/bbportal/chrome/showLogin.do
(209)

[wiley, 2012-09-14 18:58:19]

However, I see the problem without this change on both systems during
activation, and with the change I do not see the issue.

[commit-bot: I haz the power, 2012-09-14 18:59:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1

[commit-bot: I haz the power, 2012-09-14 19:09:54]

Retried try job too often for step(s) compile

[zel, 2012-09-14 20:12:57]

This is a portal JS error that's out of our control. For the reference,
I've never seen these payment portals loading without any JS error even
while they appear to be functional.


On Fri, Sep 14, 2012 at 11:57 AM, <wiley@chromium.org> wrote:

> I've tested activation on a lumpy with a built in modem and with several
> external modems on a zgb.  The re-up process seems to be broken on
> Verizon's
> side; when I agree to the ToS and click submit it hangs and I see this in
> the
> chrome log:
>
> [1184:1184:0914/114001:INFO:**CONSOLE(209)] "Uncaught TypeError: Object
> #<Object> has no method 'submit'", source:
>
https://quickaccess.**verizonwireless.com/bbportal/**chrome/showLogin.do<http...
> (209)
>
>
http://codereview.chromium.**org/10913209/<http://codereview.chromium.org/109...
>

[commit-bot: I haz the power, 2012-09-14 20:41:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1

[commit-bot: I haz the power, 2012-09-14 20:50:49]

Retried try job too often for step(s) build

[commit-bot: I haz the power, 2012-09-14 20:57:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1

[commit-bot: I haz the power, 2012-09-14 21:26:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1005

[commit-bot: I haz the power, 2012-09-15 17:39:06]

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for dinner.
Ping the relevant dude on a on-needed basis.

[commit-bot: I haz the power, 2012-09-15 18:12:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1005

[commit-bot: I haz the power, 2012-09-17 16:25:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1005

[commit-bot: I haz the power, 2012-09-18 01:58:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1005

[commit-bot: I haz the power, 2012-09-18 01:58:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1005

[commit-bot: I haz the power, 2012-09-18 20:47:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wiley@chromium.org/10913209/1005

[commit-bot: I haz the power, 2012-09-18 21:36:43]

Change committed as 157422