Move basic operation components for Drive API to chrome/browser/google_apis directory

Move basic operation components for Drive API to chrome/browser/google_apis directory

This patch is separated from http://codereview.chromium.org/10920091/

Files to be moved are as follows:
- gdata_errorcode.h
- operation_registry.{cc,h}
- operation_registry_unittest.cc
- operation_base.{cc,h}
- task_util.{cc,h}

BUG=127855
TEST=pass all existing tests
TBR=estade@chromium.org, ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156112

[nhiroki, 2012-09-11 00:24:05]

Hi, satoru-san and kochi-san

Could you review this? Thanks!

[nhiroki, 2012-09-11 00:38:15]

Sorry, I forgot to move task_util.{cc, h}.
I just uploaded new patchset.

[kochi, 2012-09-11 02:29:25]

http://codereview.chromium.org/10913184/diff/7001/chrome/browser/google_apis/...
File chrome/browser/google_apis/DEPS (right):

http://codereview.chromium.org/10913184/diff/7001/chrome/browser/google_apis/...
chrome/browser/google_apis/DEPS:14: # Temporarily needed, see
http://crbug.com/146989
Could you describe what needs to be done for DEPS file in issue tracker?

http://codereview.chromium.org/10913184/diff/7001/chrome/browser/google_apis/...
File chrome/browser/google_apis/gdata_errorcode.h (right):

http://codereview.chromium.org/10913184/diff/7001/chrome/browser/google_apis/...
chrome/browser/google_apis/gdata_errorcode.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_GDATA_GDATA_ERRORCODE_H_
Change include guard?

(ditto for the bottom #endif)

[nhiroki, 2012-09-11 04:00:30]

http://codereview.chromium.org/10913184/diff/7001/chrome/browser/google_apis/...
File chrome/browser/google_apis/DEPS (right):

http://codereview.chromium.org/10913184/diff/7001/chrome/browser/google_apis/...
chrome/browser/google_apis/DEPS:14: # Temporarily needed, see
http://crbug.com/146989
On 2012/09/11 02:29:25, Takayoshi Kochi wrote:
> Could you describe what needs to be done for DEPS file in issue tracker?

Okay, I'll describe what to do.

http://codereview.chromium.org/10913184/diff/7001/chrome/browser/google_apis/...
File chrome/browser/google_apis/gdata_errorcode.h (right):

http://codereview.chromium.org/10913184/diff/7001/chrome/browser/google_apis/...
chrome/browser/google_apis/gdata_errorcode.h:5: #ifndef
CHROME_BROWSER_CHROMEOS_GDATA_GDATA_ERRORCODE_H_
On 2012/09/11 02:29:25, Takayoshi Kochi wrote:
> Change include guard?
> 
> (ditto for the bottom #endif)

Thanks for catching! I changed it.

[nhiroki, 2012-09-11 08:05:52]

I found why build errors occur on Windows buildbot (see the result of the Patch
Set 1).
I have made a patch to fix it (http://codereview.chromium.org/10918166/).

[satorux1, 2012-09-11 15:52:15]

LGTM. Thanks!

[commit-bot: I haz the power, 2012-09-11 16:56:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/10913184/5028

[commit-bot: I haz the power, 2012-09-11 16:56:49]

Presubmit check for 10913184-5028 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/browser/chromeos/gdata/gdata_contacts_service.cc:484
    operation->set_feed_url_for_testing( \
  chrome/browser/chromeos/gdata/gdata_contacts_service.cc:593
    operation->set_feed_url_for_testing(

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome
    chrome/browser/ui/webui

Presubmit checks took 3.7s to calculate.

[nhiroki, 2012-09-11 17:13:51]

Adding TBR= estade@ for ui/webui, ben@ for gyp

Thanks!

[commit-bot: I haz the power, 2012-09-11 17:14:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nhiroki@chromium.org/10913184/5028

[commit-bot: I haz the power, 2012-09-11 20:26:22]

Change committed as 156112