Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: dart/lib/compiler/implementation/tools/mini_parser.dart

Issue 10913176: Reject non-ASCII identifiers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/compiler/implementation/scanner/token.dart ('k') | dart/tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/tools/mini_parser.dart
diff --git a/dart/lib/compiler/implementation/tools/mini_parser.dart b/dart/lib/compiler/implementation/tools/mini_parser.dart
index cb39b2c1e925fd4d537ef6c6ab0de7c862f92add..413266b92ac948d353ca7e0f84fd471e11a6c7c4 100644
--- a/dart/lib/compiler/implementation/tools/mini_parser.dart
+++ b/dart/lib/compiler/implementation/tools/mini_parser.dart
@@ -105,8 +105,6 @@ void parseFile(String filename, MyOptions options) {
} else {
print(ex);
}
- } on MalformedInputException catch (ex) {
- // Already diagnosed.
} catch (ex) {
print('Error in file: $filename');
throw;
@@ -124,17 +122,7 @@ void parseFile(String filename, MyOptions options) {
Token scan(MySourceFile source) {
Scanner scanner = new ByteArrayScanner(source.rawText);
- try {
- return scanner.tokenize();
- } on MalformedInputException catch (ex) {
- if (ex.position is Token) {
- print(formatError(ex.message, ex.position, ex.position, source));
- } else {
- Token fakeToken = new Token(QUESTION_INFO, ex.position);
- print(formatError(ex.message, fakeToken, fakeToken, source));
- }
- throw;
- }
+ return scanner.tokenize();
}
var filesWithCrashes;
« no previous file with comments | « dart/lib/compiler/implementation/scanner/token.dart ('k') | dart/tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698