Issue 10913151: Remove runtime lookup of objc_setAssociatedObject

Issue 10913151: Remove runtime lookup of objc_setAssociatedObject (Closed)

Created:
8 years, 3 months ago by sail

Modified:
8 years, 3 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove runtime lookup of objc_setAssociatedObject Now that we've dropped 10.5 support we can link to this function directly. BUG=137676 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155633

Patch Set 1 #

Patch Set 2 : " #

Total comments: 2

Patch Set 3 : address review comments #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -42 lines)			Patch
	M	chrome/common/mac/objc_zombie_unittest.mm	View	1 2	4 chunks	+7 lines, -42 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm! BUG=137676 https://chromiumcodereview.appspot.com/10913151/diff/3001/chrome/common/mac/objc_zombie_unittest.mm File chrome/common/mac/objc_zombie_unittest.mm (left): https://chromiumcodereview.appspot.com/10913151/diff/3001/chrome/common/mac/objc_zombie_unittest.mm#oldcode106 chrome/common/mac/objc_zombie_unittest.mm:106: // NOTE(shess): To test the negative, hardcode ...

8 years, 3 months ago (2012-09-09 08:19:17 UTC) #2

sail

https://chromiumcodereview.appspot.com/10913151/diff/3001/chrome/common/mac/objc_zombie_unittest.mm File chrome/common/mac/objc_zombie_unittest.mm (left): https://chromiumcodereview.appspot.com/10913151/diff/3001/chrome/common/mac/objc_zombie_unittest.mm#oldcode106 chrome/common/mac/objc_zombie_unittest.mm:106: // NOTE(shess): To test the negative, hardcode |g_objectDestruct| to ...

8 years, 3 months ago (2012-09-09 14:35:54 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/10913151/6001

8 years, 3 months ago (2012-09-09 14:36:04 UTC) #4

Change committed as 155633

Expand Messages | Collapse Messages