Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 10913118: Don't refresh policy immediately when fetched already. (Closed)

Created:
8 years, 3 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 3 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Visibility:
Public.

Description

Don't refresh policy immediately when fetched already. Avoid an immediate policy fetch in CloudPolicyRefreshScheduler for the case when the corresponding CloudPolicyClient has already downloaded policy before the refresh scheduler was instantiated. BUG=chromium:108928 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155729

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M chrome/browser/policy/cloud_policy_refresh_scheduler.cc View 1 chunk +15 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud_policy_refresh_scheduler_unittest.cc View 4 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Friendly review request.
8 years, 3 months ago (2012-09-06 19:22:52 UTC) #1
Joao da Silva
lgtm
8 years, 3 months ago (2012-09-07 12:04:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/10913118/8001
8 years, 3 months ago (2012-09-10 12:10:44 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 15:00:11 UTC) #4
Change committed as 155729

Powered by Google App Engine
This is Rietveld 408576698