Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 10913089: Adjust ChromeToMobile error logging and mitigation. (Closed)

Created:
8 years, 3 months ago by msw
Modified:
8 years, 3 months ago
Reviewers:
nyquist, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Adjust ChromeToMobile error logging and mitigation. Increase kMaxRetries for URLFetcher to 5 (common elsewhere). Decrease kDelayHours for URLFetcher to 1hr (w/exp backoff). Clear |access_token_| with new kGaiaOAuth2LoginAccessToken. Clear |access_token_| *and devices* on OnGetTokenFailure(). Handle invalid login refresh tokens as OnGetTokenFailure(). Clear token, devices, retry on 403 (auth) search responses. Add and log some new BAD_* UMA Metric enum values. (407 related to Issue 146685 and perhaps Issue 137267) LOG (Chrome, not UMA) send response data on failure. Corresponding src/tools/histograms/histograms.xml change: https://chromereviews.googleplex.com/4782033 BUG=102709, 120941, 146685 TEST=Less Chrome To Mobile failures, additional insightful logging. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155317

Patch Set 1 #

Patch Set 2 : Additional error logging and mitigation. #

Patch Set 3 : Add generic errorCode enum, always log SEND_[SUCCESS|ERROR]. #

Patch Set 4 : Fix clang error. #

Total comments: 2

Patch Set 5 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -25 lines) Patch
M chrome/browser/chrome_to_mobile_service.h View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/chrome_to_mobile_service.cc View 1 2 3 4 9 chunks +56 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
msw
Hey Tommy and Scott, please take a look; thanks!
8 years, 3 months ago (2012-09-06 02:34:58 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-06 15:59:32 UTC) #2
nyquist
https://chromiumcodereview.appspot.com/10913089/diff/11001/chrome/browser/chrome_to_mobile_service.cc File chrome/browser/chrome_to_mobile_service.cc (right): https://chromiumcodereview.appspot.com/10913089/diff/11001/chrome/browser/chrome_to_mobile_service.cc#newcode571 chrome/browser/chrome_to_mobile_service.cc:571: auth_retry_timer_.GetCurrentDelay() * 2); Should this not be for search_retry_timer_?
8 years, 3 months ago (2012-09-06 19:09:15 UTC) #3
nyquist
lgtm after fixing delta delya
8 years, 3 months ago (2012-09-06 19:21:16 UTC) #4
msw
Comment addressed, thanks for the catch! Landing. https://chromiumcodereview.appspot.com/10913089/diff/11001/chrome/browser/chrome_to_mobile_service.cc File chrome/browser/chrome_to_mobile_service.cc (right): https://chromiumcodereview.appspot.com/10913089/diff/11001/chrome/browser/chrome_to_mobile_service.cc#newcode571 chrome/browser/chrome_to_mobile_service.cc:571: auth_retry_timer_.GetCurrentDelay() * ...
8 years, 3 months ago (2012-09-06 20:07:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10913089/1006
8 years, 3 months ago (2012-09-06 20:09:01 UTC) #6
commit-bot: I haz the power
Try job failure for 10913089-1006 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-09-06 21:31:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10913089/1006
8 years, 3 months ago (2012-09-06 21:43:50 UTC) #8
commit-bot: I haz the power
Try job failure for 10913089-1006 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-09-06 23:17:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10913089/1006
8 years, 3 months ago (2012-09-06 23:19:58 UTC) #10
commit-bot: I haz the power
8 years, 3 months ago (2012-09-07 05:33:44 UTC) #11
Change committed as 155317

Powered by Google App Engine
This is Rietveld 408576698