Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10913087: uber: Remove <link rel=icon> tags (Closed)

Created:
8 years, 3 months ago by Nico
Modified:
8 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, asanka, mihaip-chromium-reviews_chromium.org, Randy Smith (Not in Mondays), Patrick Dubroy, Aaron Boodman, arv (Not doing code reviews)
Visibility:
Public.

Description

uber: Remove <link rel=icon> tags Favicons are handled by chrome/browser/resources/uber.js and the data-favicon attributes in chrome/browser/resources/uber/uber.html The tags in the subpage html do nothing but confuse me, so remove them. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155031

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/resources/extensions/extension_activity.html View 1 chunk +0 lines, -1 line 1 comment Download
M chrome/browser/resources/extensions/extensions.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/history/history.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 3 months ago (2012-09-05 17:54:44 UTC) #1
Evan Stade
lgtm except for one thing. http://codereview.chromium.org/10913087/diff/2001/chrome/browser/resources/extensions/extension_activity.html File chrome/browser/resources/extensions/extension_activity.html (left): http://codereview.chromium.org/10913087/diff/2001/chrome/browser/resources/extensions/extension_activity.html#oldcode1 chrome/browser/resources/extensions/extension_activity.html:1: <!DOCTYPE html> I don't ...
8 years, 3 months ago (2012-09-05 21:43:12 UTC) #2
Nico
On 2012/09/05 21:43:12, Evan Stade wrote: > lgtm except for one thing. > > http://codereview.chromium.org/10913087/diff/2001/chrome/browser/resources/extensions/extension_activity.html ...
8 years, 3 months ago (2012-09-05 21:46:57 UTC) #3
Nico
8 years, 3 months ago (2012-09-05 21:47:01 UTC) #4 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698