Issue 10913085: Ensure we don't leak a callback object when starting a sandboxed process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913085: Ensure we don't leak a callback object when starting a sandboxed process. (Closed)

Created:
8 years, 3 months ago by Jay Civelli

Modified:
8 years, 3 months ago

Reviewers:
Yaron

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ensure we don't leak a callback object when starting a sandboxed process. On Android we would leak a callback object if we failed to create a sanbox process. This ensures we delete it properly. BUG=None TEST=Android test shell should still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155013

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	content/browser/android/sandboxed_process_launcher.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jcivelli@chromium.org/10913085/1

8 years, 3 months ago (2012-09-05 16:49:55 UTC) #3

Change committed as 155013

Expand Messages | Collapse Messages