Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: net/net.gyp

Issue 10913083: Remove {base,net}_java dependencies from GYP client targets on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/media.gyp ('k') | sql/sql.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/net.gyp
diff --git a/net/net.gyp b/net/net.gyp
index 6b00c158094ee16621cea54e5991791ec8a19d07..282bdbb3eef81b2eb65944ad6ee6af4685d1e7ee 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -820,6 +820,14 @@
'../base/base.gyp:base',
],
'conditions': [
+ ['OS=="android" and _toolset=="target"', {
Peter Beverloo 2012/09/06 10:09:09 The OS==* conditions in this block start around li
Philippe 2012/09/06 15:49:46 Done.
+ 'dependencies': [
+ 'net_java',
+ ],
+ 'export_dependent_settings': [
+ 'net_java',
+ ],
+ }],
['chromeos==1', {
'sources!': [
'base/network_change_notifier_linux.cc',
@@ -2078,10 +2086,10 @@
'java_in_dir': '../net/android/java',
},
'dependencies': [
- '../base/base.gyp:base_java',
+ '../base/base.gyp:base',
],
'export_dependent_settings': [
- '../base/base.gyp:base_java',
+ '../base/base.gyp:base',
],
'includes': [ '../build/java.gypi' ],
},
@@ -2093,12 +2101,14 @@
'java_in_dir': '../net/android/javatests',
},
'dependencies': [
- '../base/base.gyp:base_java',
+ '../base/base.gyp:base',
'../base/base.gyp:base_java_test_support',
+ 'net_java',
],
'export_dependent_settings': [
- '../base/base.gyp:base_java',
+ '../base/base.gyp:base',
'../base/base.gyp:base_java_test_support',
+ 'net_java',
],
'includes': [ '../build/java.gypi' ],
},
« no previous file with comments | « media/media.gyp ('k') | sql/sql.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698