Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1712)

Unified Diff: content/content.gyp

Issue 10913083: Remove {base,net}_java dependencies from GYP client targets on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Peter's comment Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/content.gyp
diff --git a/content/content.gyp b/content/content.gyp
index 41b1c0294687f4cdc8f337924d1a808d667607ae..f4883eac19f78f7f1a88ca7787ab27f4ea394766 100644
--- a/content/content.gyp
+++ b/content/content.gyp
@@ -243,15 +243,10 @@
'target_name': 'content_java',
'type': 'none',
'dependencies': [
- '../base/base.gyp:base_java',
cjhopman 2012/09/06 20:29:25 I believe that the dependency on base_java here wa
Philippe 2012/09/07 09:45:57 These changes were pretty random indeed. The code
- '../net/net.gyp:net_java',
+ '../net/net.gyp:net',
'common_aidl',
'content_common',
],
- 'export_dependent_settings': [
- '../base/base.gyp:base_java',
- '../net/net.gyp:net_java',
cjhopman 2012/09/06 20:29:25 Removing these exports would make an apk that spec
Philippe 2012/09/07 09:45:57 I don't think I had strong reasons to do this. I f
- ],
'variables': {
'package_name': 'content',
'java_in_dir': '../content/public/android/java',
« build/apk_test.gypi ('K') | « chrome/chrome.gyp ('k') | content/content_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698