Old catch syntax is now an error (issue 4905)

compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.parser;
 
 import com.google.dart.compiler.ErrorCode;
 import com.google.dart.compiler.ErrorSeverity;
 import com.google.dart.compiler.SubSystem;
 
@@ skipping 13 matching lines @@
   BUILT_IN_IDENTIFIER_AS_TYPE_VARIABLE_NAME("Built-in identifier can not be used as type variable name"),
   CANNOT_MIX_OPTIONAL_AND_NAMED_PARAMETERS("Cannot mix both optional and named parameters in the same function"),
   CATCH_OR_FINALLY_EXPECTED("catch or finally clause expected."),
   CONTINUE_IN_CASE_MUST_HAVE_LABEL("'continue' in case statement must have a label as a target."),
   CONTINUE_OUTSIDE_OF_LOOP("'continue' used outside of loop or case statement"),
   DEFAULT_VALUE_CAN_NOT_BE_SPECIFIED_IN_CLOSURE(
       "Default values cannot be specified in closure parameter"),
   DEFAULT_VALUE_CAN_NOT_BE_SPECIFIED_IN_TYPEDEF(
       "Default values cannot be specified in closure type definition"),
   DEFAULT_POSITIONAL_PARAMETER("Positional parameters cannot have default values"),
-  DEPRECATED_CATCH(ErrorSeverity.WARNING, "This style of catch clause has been deprecated and will "
-      + "soon be disallowed. Please use 'on' <type> 'catch' '(' <identifier> (',' <identifier>)? ')' form."),
+  DEPRECATED_CATCH("This style of catch clause has been deprecated. Please use the 'on' <type> " +
+      "'catch' '(' <identifier> (',' <identifier>)? ')' form."),
   DEPRECATED_GETTER(ErrorSeverity.WARNING, "The presence of parentheses afer the name of the getter "
       + "has been deprecated and will soon be disallowed. Please remove the parentheses."),
   DEPRECATED_USE_OF_FACTORY_KEYWORD("Deprecated use of the 'factory' keyword: use 'default' instead"),
   DEPRECATED_RESOURCE_DIRECTIVE("The #resource directive has been deprecated and will soon be disallowed"),
   DIRECTIVE_OUT_OF_ORDER("Directive out of order"),
   DISALLOWED_ABSTRACT_KEYWORD("Abstract keyword not allowed here"),
   // TODO(zundel): error message needs JUnit test (unreachable code?)
   DISALLOWED_FACTORY_KEYWORD("Factory keyword not allowed here"),
   DISALLOWED_STATIC_KEYWORD("Static keyword not allowed here"),
   EXPECTED_ARRAY_OR_MAP_LITERAL("Expected array or map literal"),
@@ skipping 119 matching lines @@
   @Override
   public SubSystem getSubSystem() {
     return SubSystem.PARSER;
   }
 
   @Override
   public boolean needsRecompilation() {
     return true;
   }
 }