[Mac] Do not leave artifacts when using history navigation gestures.

[Mac] Do not leave artifacts when using history navigation gestures.

This also fixes a leak of HistoryOverlayController objects that was caused by
the |-dismiss| CAAnimation retaining its delegate.

BUG=119990
TEST=See steps in bug. Easily repros on crbug.com.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154851

[Nico, 2012-09-04 17:23:14]

lgtm

test would've been nice

[Robert Sesek, 2012-09-04 17:39:08]

On 2012/09/04 17:23:14, Nico wrote:
> lgtm
> 
> test would've been nice

Yes, I would have liked one, too. But I don't know of any way to synthesize a
stream of gesture events, which I think would be necessary here.

[Nico, 2012-09-04 17:52:39]

On Tue, Sep 4, 2012 at 10:39 AM, <rsesek@chromium.org> wrote:

> On 2012/09/04 17:23:14, Nico wrote:
>
>> lgtm
>>
>
>  test would've been nice
>>
>
> Yes, I would have liked one, too. But I don't know of any way to
> synthesize a
> stream of gesture events, which I think would be necessary here.
>

Sorry, it looked like the class doesn't know about events at all.

otherEventWithType:location:modifierFlags:timestamp:windowNumber:context:subtype:data1:data2:
can probably create events with the right type (NSEventTypeBeginGesture)
probably might get you the right event, but I don't know how to then set
the event phase etc.


>
>
https://chromiumcodereview.**appspot.com/10913066/<https://chromiumcodereview...
>

[Robert Sesek, 2012-09-04 21:02:33]

Added a test. PTAL.

[Nico, 2012-09-04 21:05:15]

lgtm

Thanks!

https://chromiumcodereview.appspot.com/10913066/diff/1003/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm (right):

https://chromiumcodereview.appspot.com/10913066/diff/1003/chrome/browser/ui/c...
chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm:69: [[[[mock
expect] andForwardToRealObject] andDo:quit_loop]
nifty!

https://chromiumcodereview.appspot.com/10913066/diff/1003/chrome/browser/ui/c...
chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm:79: [mock
dismiss];
This might be indented 2 too much, but I'm not sure

[Robert Sesek, 2012-09-04 21:06:36]

https://chromiumcodereview.appspot.com/10913066/diff/1003/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm (right):

https://chromiumcodereview.appspot.com/10913066/diff/1003/chrome/browser/ui/c...
chrome/browser/ui/cocoa/history_overlay_controller_unittest.mm:79: [mock
dismiss];
On 2012/09/04 21:05:15, Nico wrote:
> This might be indented 2 too much, but I'm not sure

Blocks are indented 4 spaces from the declaration's level.

[commit-bot: I haz the power, 2012-09-04 21:07:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10913066/1003

[commit-bot: I haz the power, 2012-09-04 23:38:35]

Change committed as 154851