Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10913059: Renaming FYI bots to follow chromium standards (Closed)

Created:
8 years, 3 months ago by Isaac (away)
Modified:
8 years, 3 months ago
Reviewers:
Peter Beverloo, cmp, bulach
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 7 chunks +26 lines, -28 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Isaac (away)
8 years, 3 months ago (2012-09-04 03:10:44 UTC) #1
bulach
lgtm (but not an OWNER), and some nits below.. thanks for cleaning this up, it's ...
8 years, 3 months ago (2012-09-04 09:11:42 UTC) #2
Peter Beverloo
https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg#newcode152 masters/master.chromium.fyi/master.cfg:152: 'Android Nexus7 Tester (dbg)']) I'm unsure about the "Nexus7" ...
8 years, 3 months ago (2012-09-04 10:07:29 UTC) #3
Isaac (away)
+cmp
8 years, 3 months ago (2012-09-06 05:32:34 UTC) #4
Isaac (away)
https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg#newcode152 masters/master.chromium.fyi/master.cfg:152: 'Android Nexus7 Tester (dbg)']) That's longer than I'd prefer, ...
8 years, 3 months ago (2012-09-07 07:42:09 UTC) #5
Isaac (away)
https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg#newcode152 masters/master.chromium.fyi/master.cfg:152: 'Android Nexus7 Tester (dbg)']) If we're going to use ...
8 years, 3 months ago (2012-09-10 00:07:42 UTC) #6
Isaac (away)
https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg#newcode152 masters/master.chromium.fyi/master.cfg:152: 'Android Nexus7 Tester (dbg)']) Note that JB is redundant ...
8 years, 3 months ago (2012-09-10 00:08:53 UTC) #7
Peter Beverloo
My worry with assuming a Galaxy Nexus with JellyBean is that we don't know what ...
8 years, 3 months ago (2012-09-10 00:14:36 UTC) #8
cmp
lgtm with a change (Tester -> Tests) https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://chromiumcodereview.appspot.com/10913059/diff/1/masters/master.chromium.fyi/master.cfg#newcode150 masters/master.chromium.fyi/master.cfg:150: builderNames=['Android JB ...
8 years, 3 months ago (2012-09-10 00:14:40 UTC) #9
Isaac (away)
Chatted w/ peter and found good names for the new bots. Changed Testers -> Tests. ...
8 years, 3 months ago (2012-09-10 06:03:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10913059/6002
8 years, 3 months ago (2012-09-10 06:06:41 UTC) #11
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 06:07:32 UTC) #12
Change committed as 155670

Powered by Google App Engine
This is Rietveld 408576698