Issue 10913050: views: Remove content dependency from views package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10913050: views: Remove content dependency from views package. (Closed)

Created:
8 years, 3 months ago by tfarina

Modified:
8 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Remove content dependency from views package. BUG=105557, 141187 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154629

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	ui/views/views.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 3 months ago (2012-09-04 15:28:22 UTC) #2

LGTM


On Sat, Sep 1, 2012 at 12:56 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> TBRing...
>
> Description:
> views: Remove content dependency from views package.
>
> BUG=105557,141187
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10913050/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ui/views/views.gyp
>
>
> Index: ui/views/views.gyp
> diff --git a/ui/views/views.gyp b/ui/views/views.gyp
> index 015c1525036847797ecef73dd9a2c9**64fb707b3a..**
> d745b11020eccc5493c7982d2a67f6**47df180744 100644
> --- a/ui/views/views.gyp
> +++ b/ui/views/views.gyp
> @@ -29,7 +29,6 @@
>          '../../base/base.gyp:base_**i18n',
>          '../../base/third_party/**dynamic_annotations/dynamic_**
> annotations.gyp:dynamic_**annotations',
>          '../../build/temp_gyp/**googleurl.gyp:googleurl',
> -        '../../content/content.gyp:**content',
>          '../../skia/skia.gyp:skia',
>          '../../third_party/icu/icu.**gyp:icui18n',
>          '../../third_party/icu/icu.**gyp:icuuc',
>
>
>

Expand Messages | Collapse Messages