Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10913043: Convert the popups pyauto test to browser_tests. (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Nirnimesh, kkania, anantha, robertshield, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Convert the popups pyauto test to browser_tests. testPopupBlockedEverySec: I didn't port this since it seemed redundant with other tests, and it's permanently disabled anyways. testPopupBlockerEnabled is a duplicate of a subset of testLaunchBlockedPopup. same with the incognito version testAllowPopupsFromExternalSite was really just testing that an exception works, not that it's going to an external networkw which we don't want for tests. I rewrote it to use a local url. testBlockedPopupNotShowInHistory is testing something that's not the current behavior, which is why it's disabled. if this changes, someone can add a test for the new behavior then BUG=143637, 83827, 47935 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154602

Patch Set 1 #

Patch Set 2 : fix race conditions in tests that bots exposed #

Patch Set 3 : fix cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -326 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 4 chunks +1 line, -68 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 3 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/popup_blocker_browsertest.cc View 1 2 2 chunks +141 lines, -12 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 3 chunks +17 lines, -0 lines 0 comments Download
A chrome/test/data/popup_blocker/popup-many.html View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/test/data/popup_blocker/popup-on-unload.html View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 5 chunks +0 lines, -11 lines 0 comments Download
D chrome/test/functional/popups.py View 1 chunk +0 lines, -177 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 3 months ago (2012-08-31 22:08:35 UTC) #1
Ben Goodger (Google)
8 years, 3 months ago (2012-08-31 22:38:38 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698