Reland DownloadManager::GetAllDownloads actually does now

chrome/browser/automation/automation_provider_observers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/automation_provider_observers.h"
 
 #include <deque>
 #include <string>
 #include <vector>
 
@@ skipping 1413 matching lines @@
           .SendError("Cannot convert ID of prior download to integer.");
       delete this;
       return;
     }
   }
   download_manager_->AddObserver(this);  // Will call initial ModelChanged().
 }
 
 AllDownloadsCompleteObserver::~AllDownloadsCompleteObserver() {}
 
-void AllDownloadsCompleteObserver::ModelChanged(DownloadManager* manager) {
-  DCHECK_EQ(manager, download_manager_);
-  // The set of downloads in the download manager has changed.  If there are
-  // any new downloads that are still in progress, add them to the pending list.
-  std::vector<DownloadItem*> downloads;
-  download_manager_->GetAllDownloads(FilePath(), &downloads);
-  for (std::vector<DownloadItem*>::iterator it = downloads.begin();
-       it != downloads.end(); ++it) {
-    if ((*it)->GetState() == DownloadItem::IN_PROGRESS &&
-        pre_download_ids_.find((*it)->GetId()) == pre_download_ids_.end()) {
-      (*it)->AddObserver(this);
-      pending_downloads_.insert(*it);
-    }
+
+void AllDownloadsCompleteObserver::OnDownloadCreated(
+    DownloadManager* manager, DownloadItem* item) {
+  if (pre_download_ids_.find(item->GetId()) == pre_download_ids_.end()) {
+    item->AddObserver(this);
+    pending_downloads_.insert(item);
   }
-  ReplyIfNecessary();
 }
 
 void AllDownloadsCompleteObserver::OnDownloadUpdated(DownloadItem* download) {
   // If the current download's status has changed to a final state (not state
   // "in progress"), remove it from the pending list.
   if (download->GetState() != DownloadItem::IN_PROGRESS) {
     download->RemoveObserver(this);
     pending_downloads_.erase(download);
     ReplyIfNecessary();
   }
@@ skipping 1398 matching lines @@
       if (automation_) {
         AutomationJSONReply(automation_, reply_message_.release())
             .SendSuccess(NULL);
       }
       delete this;
     }
   } else {
     NOTREACHED();
   }
 }