chrome/browser/extensions/webstore_installer.cc - Issue 10912183: Remove DownloadManager::GetDownloadItem in favor of GetDownload()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 10912183: Remove DownloadManager::GetDownloadItem in favor of GetDownload() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 88e68ddf40ec39c9fccd62a4c2ebb5f5ed1fe2aa..ffae6402dcf5fcb74cdc07ea4ac88cc8e8b47c12 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -282,6 +282,8 @@ void WebstoreInstaller::OnDownloadStarted(DownloadId id, net::Error error) {

if (!download_manager)

return;

download_item_ = download_manager->GetDownload(id.local());

+ // TODO(benjhayden): DCHECK(item && item->IsInProgress()) after investigating

+ // the relationship between net::OK and invalid id.

if (download_item_) {

download_item_->AddObserver(this);

if (approval_.get())