Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 10912156: Move SessionID, CaptureVisibleTabFunction to WebContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase atop the extension tab helper change Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tab_util.cc
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index 7af66072c296232cfb8375b37f9f1143ce8c8330..09d20e039b190178684f99b321227c103094fcc3 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -49,7 +49,7 @@ int ExtensionTabUtil::GetWindowIdOfTabStripModel(
}
int ExtensionTabUtil::GetTabId(const WebContents* web_contents) {
- return SessionID::IdForTab(TabContents::FromWebContents(web_contents));
+ return SessionID::IdForTab(web_contents);
}
std::string ExtensionTabUtil::GetTabStatusText(bool is_loading) {
@@ -57,8 +57,7 @@ std::string ExtensionTabUtil::GetTabStatusText(bool is_loading) {
}
int ExtensionTabUtil::GetWindowIdOfTab(const WebContents* web_contents) {
- return SessionID::IdForWindowContainingTab(
- TabContents::FromWebContents(web_contents));
+ return SessionID::IdForWindowContainingTab(web_contents);
}
DictionaryValue* ExtensionTabUtil::CreateTabValue(
@@ -219,7 +218,7 @@ bool ExtensionTabUtil::GetTabById(int tab_id,
TabStripModel* target_tab_strip = target_browser->tab_strip_model();
for (int i = 0; i < target_tab_strip->count(); ++i) {
TabContents* target_contents = target_tab_strip->GetTabContentsAt(i);
- if (SessionID::IdForTab(target_contents) == tab_id) {
+ if (SessionID::IdForTab(target_contents->web_contents()) == tab_id) {
if (browser)
*browser = target_browser;
if (tab_strip)
« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model.cc ('k') | chrome/browser/extensions/page_action_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698