chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc - Issue 10912156: Move SessionID, CaptureVisibleTabFunction to WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

Issue 10912156: Move SessionID, CaptureVisibleTabFunction to WebContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase atop the extension tab helper change Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

index 835076252229743590e4ce7aa38d1a428399dcb4..74655c04483c7c12fdc42a9960e6d59901ed74be 100644

--- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

+++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

@@ -775,7 +775,7 @@ ToDataUrlOffscreenTabFunction::ToDataUrlOffscreenTabFunction() {}

ToDataUrlOffscreenTabFunction::~ToDataUrlOffscreenTabFunction() {}

bool ToDataUrlOffscreenTabFunction::GetTabToCapture(

- WebContents** web_contents, TabContents** tab_contents) {

+ WebContents** web_contents) {

int offscreen_tab_id;

EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &offscreen_tab_id));

@@ -788,7 +788,6 @@ bool ToDataUrlOffscreenTabFunction::GetTabToCapture(

return false;

*web_contents = offscreen_tab->web_contents();

- *tab_contents = offscreen_tab->tab_contents();

return true;

}