Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10912156: Move SessionID, CaptureVisibleTabFunction to WebContents. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina, marja+watch_chromium.org
Visibility:
Public.

Description

Move SessionID, CaptureVisibleTabFunction to WebContents. BUG=107201 TEST=no visible change TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155811

Patch Set 1 #

Patch Set 2 : missing include #

Patch Set 3 : again #

Patch Set 4 : rebase atop the extension tab helper change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -51 lines) Patch
M chrome/browser/extensions/active_tab_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/script_badge_apitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 1 2 3 7 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/page_action_controller.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/page_action_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/script_badge_controller.cc View 1 2 3 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/sessions/session_id.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_id.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Avi (use Gerrit)
8 years, 3 months ago (2012-09-07 21:34:08 UTC) #1
marja
lgtm
8 years, 3 months ago (2012-09-10 07:55:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10912156/7003
8 years, 3 months ago (2012-09-10 13:58:51 UTC) #3
commit-bot: I haz the power
Presubmit check for 10912156-7003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-10 13:58:57 UTC) #4
Avi (use Gerrit)
Ben TBR as super owner.
8 years, 3 months ago (2012-09-10 14:02:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10912156/7003
8 years, 3 months ago (2012-09-10 14:02:45 UTC) #6
Ben Goodger (Google)
lgtm
8 years, 3 months ago (2012-09-10 15:38:30 UTC) #7
commit-bot: I haz the power
Commit queue failed due to new patchset.
8 years, 3 months ago (2012-09-10 17:54:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10912156/12002
8 years, 3 months ago (2012-09-10 17:54:52 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 20:21:44 UTC) #10 
Change committed as 155811

Powered by Google App Engine
This is Rietveld 408576698