Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: pkg/intl/number_format.dart

Issue 10912147: Change our 'is int' check to use Math.floor instead of a smi check. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | pkg/pkg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/number_format.dart
===================================================================
--- pkg/intl/number_format.dart (revision 12017)
+++ pkg/intl/number_format.dart (working copy)
@@ -156,7 +156,7 @@
// point value, in which case we reduce it until it is small enough
// to be printed as an integer and pad the remainder with zeros.
var paddingDigits = new StringBuffer();
- while (intValue is! int) {
+ while ((intValue & 0x7fffffff) != intValue) {
paddingDigits.add(symbols.ZERO_DIGIT);
intValue = (intValue / 10).toInt();
}
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | pkg/pkg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698