Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 10912142: [chromeos] Wait for initial page load after login (Closed)

Created:
8 years, 3 months ago by Nirnimesh
Modified:
8 years, 3 months ago
Reviewers:
craigdh, jam
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

[chromeos] Wait for initial page load after login Login() automation call should wait for initial chrome to load at least one page (could be NTP). Successive automation calls (say url navigation) can then be reliably performed. This ensures that when we collect screenshots after login in autotest, we get that of the state after login (currently it often shows the login spinner because it's too soon) BUG=chromium-os:34102 TEST=login_LoginSuccess, desktopui_UrlFetch Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155926

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Patch Set 3 : comment #

Total comments: 2

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/browser/automation/automation_event_observers.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_event_observers_chromeos.cc View 1 2 3 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nirnimesh
I haven't been able to verify this yet (chromium breakage on tot), but I'll do ...
8 years, 3 months ago (2012-09-07 01:35:08 UTC) #1
craigdh
lgtm (assuming it works). Just one comment requesting additional logging. http://codereview.chromium.org/10912142/diff/1/chrome/browser/automation/automation_event_observers_chromeos.cc File chrome/browser/automation/automation_event_observers_chromeos.cc (right): http://codereview.chromium.org/10912142/diff/1/chrome/browser/automation/automation_event_observers_chromeos.cc#newcode37 ...
8 years, 3 months ago (2012-09-07 16:30:05 UTC) #2
Nirnimesh
+jam for owners http://codereview.chromium.org/10912142/diff/1/chrome/browser/automation/automation_event_observers_chromeos.cc File chrome/browser/automation/automation_event_observers_chromeos.cc (right): http://codereview.chromium.org/10912142/diff/1/chrome/browser/automation/automation_event_observers_chromeos.cc#newcode37 chrome/browser/automation/automation_event_observers_chromeos.cc:37: } On 2012/09/07 16:30:05, craigdh wrote: ...
8 years, 3 months ago (2012-09-11 00:28:20 UTC) #3
jam
lgtm https://codereview.chromium.org/10912142/diff/6001/chrome/browser/automation/automation_event_observers_chromeos.cc File chrome/browser/automation/automation_event_observers_chromeos.cc (right): https://codereview.chromium.org/10912142/diff/6001/chrome/browser/automation/automation_event_observers_chromeos.cc#newcode5 chrome/browser/automation/automation_event_observers_chromeos.cc:5: #include "content/public/browser/notification_service.h" nit: order https://codereview.chromium.org/10912142/diff/6001/chrome/browser/automation/automation_event_observers_chromeos.cc#newcode50 chrome/browser/automation/automation_event_observers_chromeos.cc:50: nit: extra ...
8 years, 3 months ago (2012-09-11 00:34:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nirnimesh@chromium.org/10912142/9001
8 years, 3 months ago (2012-09-11 00:41:36 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 02:53:24 UTC) #6
Change committed as 155926

Powered by Google App Engine
This is Rietveld 408576698