Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 10912139: stop shipping ppNaClPlugin in the NaCL SDK (Closed)

Created:
8 years, 3 months ago by Sam Clegg
Modified:
8 years, 3 months ago
Visibility:
Public.

Description

stop shipping ppNaClPlugin in the SDK BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ppapi/native_client/src/trusted/plugin/build.scons View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Sam Clegg
8 years, 3 months ago (2012-09-06 23:55:31 UTC) #1
bradn
lgtm
8 years, 3 months ago (2012-09-07 00:01:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10912139/1
8 years, 3 months ago (2012-09-07 00:43:02 UTC) #3
commit-bot: I haz the power
Presubmit check for 10912139-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-07 00:43:04 UTC) #4
sbc
Noel, can you approve this? On Thu, Sep 6, 2012 at 5:43 PM, <commit-bot@chromium.org> wrote: ...
8 years, 3 months ago (2012-09-07 00:46:29 UTC) #5
noelallen1
LGTM Make sure you run the try bots not just CQ. CQ does not run ...
8 years, 3 months ago (2012-09-07 17:15:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10912139/1
8 years, 3 months ago (2012-09-07 21:57:48 UTC) #7
commit-bot: I haz the power
Presubmit check for 10912139-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-07 21:57:50 UTC) #8
Sam Clegg
Could you LGTM this with your google account noel?
8 years, 3 months ago (2012-09-07 22:31:47 UTC) #9
noelallen_use_chromium
lgtm
8 years, 3 months ago (2012-09-07 22:32:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/10912139/1
8 years, 3 months ago (2012-09-07 22:56:51 UTC) #11
commit-bot: I haz the power
8 years, 3 months ago (2012-09-08 01:28:03 UTC) #12
Change committed as 155549

Powered by Google App Engine
This is Rietveld 408576698