runtime/vm/intermediate_language.h - Issue 10912120: Restoring assert that deopt_id() should be accessed only if the instruction can deoptimize. Print r…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.h

Issue 10912120: Restoring assert that deopt_id() should be accessed only if the instruction can deoptimize. Print r… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.h

===================================================================

--- runtime/vm/intermediate_language.h (revision 11927)

+++ runtime/vm/intermediate_language.h (working copy)

@@ -275,7 +275,10 @@

virtual Tag tag() const = 0;

- intptr_t deopt_id() const { return deopt_id_; }

+ intptr_t deopt_id() const {

+ ASSERT(CanDeoptimize());

+ return deopt_id_;

+ }

bool IsBlockEntry() { return (AsBlockEntry() != NULL); }

virtual BlockEntryInstr* AsBlockEntry() { return NULL; }

@@ -2866,7 +2869,9 @@

}

virtual intptr_t DeoptimizationTarget() const {

- return deopt_id();

+ // Direct access since this instuction cannot deoptimize, and the deopt-id

+ // was inherited from another instuction that could deoptimize.

+ return deopt_id_;

}

DECLARE_INSTRUCTION(UnboxedDoubleBinaryOp)

« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »