Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10912120: Restoring assert that deopt_id() should be accessed only if the instruction can deoptimize. Print r… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 __ Bind(&done); 99 __ Bind(&done);
100 } 100 }
101 #endif 101 #endif
102 __ LeaveFrame(); 102 __ LeaveFrame();
103 __ ret(); 103 __ ret();
104 104
105 // Generate 1 byte NOP so that the debugger can patch the 105 // Generate 1 byte NOP so that the debugger can patch the
106 // return pattern with a call to the debug stub. 106 // return pattern with a call to the debug stub.
107 __ nop(1); 107 __ nop(1);
108 compiler->AddCurrentDescriptor(PcDescriptors::kReturn, 108 compiler->AddCurrentDescriptor(PcDescriptors::kReturn,
109 deopt_id(), 109 Isolate::kNoDeoptId,
110 token_pos()); 110 token_pos());
111 } 111 }
112 112
113 113
114 LocationSummary* ClosureCallInstr::MakeLocationSummary() const { 114 LocationSummary* ClosureCallInstr::MakeLocationSummary() const {
115 const intptr_t kNumInputs = 0; 115 const intptr_t kNumInputs = 0;
116 const intptr_t kNumTemps = 1; 116 const intptr_t kNumTemps = 1;
117 LocationSummary* result = 117 LocationSummary* result =
118 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall); 118 new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kCall);
119 result->set_out(Location::RegisterLocation(EAX)); 119 result->set_out(Location::RegisterLocation(EAX));
(...skipping 2126 matching lines...) Expand 10 before | Expand all | Expand 10 after
2246 __ j(ABOVE_EQUAL, deopt); 2246 __ j(ABOVE_EQUAL, deopt);
2247 } 2247 }
2248 } 2248 }
2249 2249
2250 2250
2251 } // namespace dart 2251 } // namespace dart
2252 2252
2253 #undef __ 2253 #undef __
2254 2254
2255 #endif // defined TARGET_ARCH_X64 2255 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698