Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 10912105: Allow chrome.management.setEnabled() to re-enable crashed extensions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/management/management_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/management/management_api.cc
diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc
index bfe42aebb2960408182bbee525440d1a851ce0f8..d21d35a589000253435bb2a4bcb7c434b9afd4ec 100644
--- a/chrome/browser/extensions/api/management/management_api.cc
+++ b/chrome/browser/extensions/api/management/management_api.cc
@@ -454,20 +454,6 @@ bool SetEnabledFunction::RunImpl() {
return false;
}
- // The extension may have been unloaded due to a crash.
- if (service()->GetTerminatedExtension(extension_id_)) {
- if (params->enabled) {
- service()->ReloadExtension(extension_id_);
- } else {
- // Treat setEnabled(false) when the extension has crashed as a no-op.
- BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
- base::Bind(&SetEnabledFunction::SendResponse, this, true));
- return true;
- }
- }
-
const extensions::ManagementPolicy* policy = extensions::ExtensionSystem::Get(
profile())->management_policy();
if (!policy->UserMayModifySettings(extension, NULL)) {
« no previous file with comments | « no previous file | chrome/browser/extensions/api/management/management_api_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698