Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 10912098: Fix crash if window is destroyed while dragging it. (Closed)

Created:
8 years, 3 months ago by sky
Modified:
8 years, 3 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fix crash if window is destroyed while dragging it. BUG=146390 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155055

Patch Set 1 #

Patch Set 2 : More comments #

Total comments: 1

Patch Set 3 : virtual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -16 lines) Patch
M ash/wm/default_window_resizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/default_window_resizer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.h View 1 5 chunks +13 lines, -4 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 1 2 9 chunks +79 lines, -12 lines 0 comments Download
M ash/wm/window_resizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter_unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
8 years, 3 months ago (2012-09-05 16:50:24 UTC) #1
Ben Goodger (Google)
lgtm http://codereview.chromium.org/10912098/diff/2001/ash/wm/toplevel_window_event_filter.cc File ash/wm/toplevel_window_event_filter.cc (right): http://codereview.chromium.org/10912098/diff/2001/ash/wm/toplevel_window_event_filter.cc#newcode59 ash/wm/toplevel_window_event_filter.cc:59: ~ScopedWindowResizer(); virtual ~
8 years, 3 months ago (2012-09-05 18:24:29 UTC) #2
sky
Fixed
8 years, 3 months ago (2012-09-05 20:51:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10912098/5001
8 years, 3 months ago (2012-09-05 20:58:19 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-05 22:48:50 UTC) #5
Try job failure for 10912098-5001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698