Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 10912095: Fix Clang compilation error on Android in libevent.gyp. (Closed)

Created:
8 years, 3 months ago by Philippe
Modified:
8 years, 3 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, bulach, digit1
Visibility:
Public.

Description

Fix Clang compilation error on Android in libevent.gyp. This is part of Chrome for Android upstreaming. This fixes the following issue we encountered downstream recently due to 'base' being built for both the host and target but without distinguishing the compilation flags properly: third_party/libevent/http.c:561:6: error: implicitly declaring library function 'strlcpy' with type 'unsigned long (char *, const char *, unsigned long)' [-Werror] Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/libevent/libevent.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Philippe
8 years, 3 months ago (2012-09-05 16:51:03 UTC) #1
hans
On 2012/09/05 16:51:03, Philippe wrote: lgtm, thanks
8 years, 3 months ago (2012-09-05 17:03:20 UTC) #2
michaelbai
lgtm
8 years, 3 months ago (2012-09-05 17:41:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/10912095/1
8 years, 3 months ago (2012-09-06 08:03:44 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 11:04:47 UTC) #5
Change committed as 155164

Powered by Google App Engine
This is Rietveld 408576698