gesture recognizer: Plug a leak.

gesture recognizer: Plug a leak.

BUG=146465
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154963

[oshima, 2012-09-05 05:00:53]

can you remove suppression?

http://codereview.chromium.org/10912091/diff/1/ui/base/gestures/gesture_recog...
File ui/base/gestures/gesture_recognizer_impl.cc (right):

http://codereview.chromium.org/10912091/diff/1/ui/base/gestures/gesture_recog...
ui/base/gestures/gesture_recognizer_impl.cc:338: current_gestures->weak_clear();
I don't fully understand why this is not like

if (!gestures.get()) {
  gestures.reset(current_gestures.release())
} else {
  gestures->insert(gestures->end(), current_gestures->begin(),
                                    current_gestures->end());
  current_gestures->weak_clear();
}

but probably I just don't know this code.

[oshima, 2012-09-05 05:02:03]

On 2012/09/05 05:00:53, oshima wrote:
> can you remove suppression?

ah sorry, it's not landed yet. please ignore this.
> 
>
http://codereview.chromium.org/10912091/diff/1/ui/base/gestures/gesture_recog...
> File ui/base/gestures/gesture_recognizer_impl.cc (right):
> 
>
http://codereview.chromium.org/10912091/diff/1/ui/base/gestures/gesture_recog...
> ui/base/gestures/gesture_recognizer_impl.cc:338:
current_gestures->weak_clear();
> I don't fully understand why this is not like
> 
> if (!gestures.get()) {
>   gestures.reset(current_gestures.release())
> } else {
>   gestures->insert(gestures->end(), current_gestures->begin(),
>                                     current_gestures->end());
>   current_gestures->weak_clear();
> }
> 
> but probably I just don't know this code.

[sadrul, 2012-09-05 12:51:59]

http://codereview.chromium.org/10912091/diff/1/ui/base/gestures/gesture_recog...
File ui/base/gestures/gesture_recognizer_impl.cc (right):

http://codereview.chromium.org/10912091/diff/1/ui/base/gestures/gesture_recog...
ui/base/gestures/gesture_recognizer_impl.cc:338: current_gestures->weak_clear();
On 2012/09/05 05:00:53, oshima wrote:
> I don't fully understand why this is not like
> 
> if (!gestures.get()) {
>   gestures.reset(current_gestures.release())
> } else {
>   gestures->insert(gestures->end(), current_gestures->begin(),
>                                     current_gestures->end());
>   current_gestures->weak_clear();
> }
> 
> but probably I just don't know this code.

Done.

[oshima, 2012-09-05 15:30:03]

lgtm