favicon handler: Consider all frames when receiving favicons from the history db

favicon handler: Consider all frames when receiving favicons from the history db

Also use SelectFaviconFrames() for resizing.

This is a prerequisite for serving hidpi favicons for (most) webui pages.

BUG=145228
TEST=On a retina mac, go to a webui page. The favicon is now
pixel-scaled instead of linearly interpolated. Go to any page where 
the favicon is served from history. The same happens here.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154957

[sky, 2012-09-04 23:24:08]

Peter is working on getting all this working. Better to have him review this.

[pkotwicz, 2012-09-05 14:08:46]

LGTM with nits

http://codereview.chromium.org/10912088/diff/1/chrome/browser/favicon/favicon...
File chrome/browser/favicon/favicon_handler.cc (right):

http://codereview.chromium.org/10912088/diff/1/chrome/browser/favicon/favicon...
chrome/browser/favicon/favicon_handler.cc:237: const
std::vector<history::FaviconBitmapResult>& favicon_bitmap_results) {
Nit:
Can we put the code for converting from a FaviconBitmapResult vector to a
gfx::Image into FaviconUtil?
There is some similar code in FaviconService.

Heads up:
We will have to eventually add a non resized version of the bitmaps into
FaviconStatus as well to deal with the call to favicon_service->SetFavicon() in
instant_controller.

[Nico, 2012-09-05 14:48:54]

Thanks!

https://chromiumcodereview.appspot.com/10912088/diff/1/chrome/browser/favicon...
File chrome/browser/favicon/favicon_handler.cc (right):

https://chromiumcodereview.appspot.com/10912088/diff/1/chrome/browser/favicon...
chrome/browser/favicon/favicon_handler.cc:237: const
std::vector<history::FaviconBitmapResult>& favicon_bitmap_results) {
On 2012/09/05 14:08:46, pkotwicz wrote:
> Nit:
> Can we put the code for converting from a FaviconBitmapResult vector to a
> gfx::Image into FaviconUtil?
> There is some similar code in FaviconService.
> 
> Heads up:
> We will have to eventually add a non resized version of the bitmaps into
> FaviconStatus as well to deal with the call to favicon_service->SetFavicon()
in
> instant_controller.

Done.

[commit-bot: I haz the power, 2012-09-05 14:49:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10912088/1004

[sky, 2012-09-05 14:49:43]

LGTM 2