[android] Remove extra adb newlines from buildbot log

[android] Remove extra adb newlines from buildbot log

Pexpect runs adb within a pseudo-tty device (see
http://www.noah.org/wiki/pexpect), so any '\n' printed by adb is written
as '\r\n' to the logfile. Since adb already uses '\r\n' to terminate
lines, the log ends up having '\r\r\n' at the end of each line. When
this is rendered within a <pre> element in the buildbot log, an empty
line is shown between each actual log line.

This patch replaces the above with a single '\n' in the logfile stream,
making the buildbot log easier to read.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154760

[bulach, 2012-09-04 11:22:56]

lgtm, thanks! just nits:

https://chromiumcodereview.appspot.com/10912072/diff/1/build/android/pylib/an...
File build/android/pylib/android_commands.py (right):

https://chromiumcodereview.appspot.com/10912072/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:711: class NewLineNormalizer:
nit: (object)

https://chromiumcodereview.appspot.com/10912072/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:712: """A file-like object that
normalizes end-of-line characters in the
nit: needs to be one line and end with a period, something like:
"""A file-like object to normalize EOLs to \n."""

after that, it can have more detailed information :)

https://chromiumcodereview.appspot.com/10912072/diff/1/build/android/pylib/an...
build/android/pylib/android_commands.py:729: self.output.flush()
nit: add a \n before 730

[commit-bot: I haz the power, 2012-09-04 12:34:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@google.com/10912072/4001

[commit-bot: I haz the power, 2012-09-04 14:16:52]

Try job failure for 10912072-4001 (retry) on linux_rel for step
"interactive_ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Isaac (away), 2012-09-05 08:22:05]

This is awesome!  Thanks Sami!