Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10912063: events: Get rid of GestureStatus in favour of EventResult. (Closed)

Created:
8 years, 3 months ago by sadrul
Modified:
8 years, 3 months ago
CC:
chromium-reviews, asanka, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, Randy Smith (Not in Mondays), dcheng, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

events: Get rid of GestureStatus in favour of EventResult. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154721

Patch Set 1 #

Patch Set 2 : all #

Patch Set 3 : merge #

Patch Set 4 : tot-merge #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -338 lines) Patch
M ash/accelerators/accelerator_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/launcher/launcher_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_button.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/status_area_widget_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_notification_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_notification_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/tray_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M ash/tooltips/tooltip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/touch/touch_observer_hud.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/app_list_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/event_rewriter_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_rewriter_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overlay_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overlay_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/panel_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_window_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_gesture_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M ash/wm/system_modal_container_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/toplevel_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_filter.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M ash/wm/user_activity_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/window_modality_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_modality_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/frame_maximize_button.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/workspace/workspace_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.h View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/base_tab.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/contents_view.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/event_filter.h View 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/aura/event_filter.cc View 2 2 chunks +4 lines, -5 lines 0 comments Download
M ui/aura/event_filter_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 3 chunks +6 lines, -8 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 2 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/shared/compound_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/shared/compound_event_filter.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/shared/compound_event_filter_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/shared/input_method_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/shared/input_method_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/test/test_event_filter.h View 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_event_filter.cc View 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/test/test_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/window_delegate.h View 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_delegate.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/window_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/events.h View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download
M ui/base/events/event_handler.h View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/custom_button.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/link.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/link.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_host_root_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_host_root_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/submenu_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/submenu_view.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/scroll_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scroll_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/slider.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ui/views/view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/view_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/x11_desktop_window_move_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/x11_desktop_window_move_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/x11_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/x11_window_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
8 years, 3 months ago (2012-09-03 14:02:07 UTC) #1
Ben Goodger (Google)
8 years, 3 months ago (2012-09-03 15:42:52 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698